-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
Hello list,
On 15/03/16 14:18, Arturo Filastò wrote:
[...]
Basically these tests will try to run the lantern and psiphon tool, then attempt to connect to a certain website with it and verify if the response it gets from the website is the expected one.
In the past it was possible to configure the URL to be fetched and the response body that is expected with a sane default.
I have changed this to no longer be the case and instead use a hardcoded value of a website that we expect to not change in the future and an expected result for it. In the specific case it’s http://www.google.com/humans.txt
I believe we can have both! By using default parameters -sane default we are allowing the tests to run without requiring extra arguments. This satisfies:
- - Users that just want to run the test without any parameters set. Either because they are not aware of the "correct" parameters or they don't want to do any further tests rather than just check if lantern or psiphon bootstraps and works.
- - Users that (probably) know what they do and would like to change the default (sane default) parameters. They would like to test if other URLs are reachable via lantern or psiphon or trigger different responses or do something else without doing changes into the code.
Does this makes more sense?
Just for reference the current sane default is to check the URL: http://www.google.com/humans.txt
~Vasilis