[tor-project] Tor Browser team meeting notes, 19 Nov 2018
Georg Koppen
gk at torproject.org
Thu Nov 22 09:10:00 UTC 2018
Hi!
Here come the notes to our weekly meeting we had on Monday (I know, it's
late, but not too late :) ). The IRC log can be found at:
http://meetbot.debian.net/tor-meeting/2018/tor-meeting.2018-11-19-18.59.log.txt
And the items from our pad are pasted below, for your convenience:
Discussion:
-release preparations (GeKo: we are still on track to have a release
by end of the week)
-topics for the all hands meeting
mcs and brade:
Last week:
- Finished #27239 (TB team feedback on jump-to-80% work).
- Worked on #28196 (about:preferences#general is not properly
translated anymore).
- Participated in design discussions for #25658 (Activity 2.1:
Improve user understanding and user control by clarifying Tor Browser's
security features).
This week:
- (We will be away from work this Tuesday, November 20 through
Friday, November 23).
- Help with code reviews.
pospeselr:
Last week:
- Uplifted patch for #26540 to latest gecko-dev
- filed bug https://bugzilla.mozilla.org/show_bug.cgi?id=1506693
- began work on #25702 ( tor-browser rebranding )
- currently have verification builds for Linux and windows using
nightly assets from last week, currently building macOS
- some open questions:
- firefox has built in 'branding' directories which can be pointed
to in the mozconfig; does it make sense from the tor-browser-build
perspective to dynamically append the required ac_add_option line based
on the make target (release, nightly, alpha), or should we add new
mozconfigs for each sku?
(11/19/2018 11:12:11 AM) boklm: could it be set using an environment
variable that we define in the build script?
(11/19/2018 11:12:33 AM) sysrqb: i think it's simply add
'--with-branding=browser/branding/nightly' along with the other ./mach
configure options we pass within the build tor-browser-build build script
- do we want to customize the NSIS installer on windows with
appropriate branding (release, nightly, alpha)? (Separate install path
for alpha,release,nightly)
(11/19/2018 11:15:45 AM) GeKo: fine with me, but let's do it in a
different bug
- do we want to migrate 'About Tor Browser' dialog override ( seen
here: https://share.riseup.net/#GouAI9HHZkLR9HbbVxviOg ) from torbutton
to tor-browser? Current changeset requires updated the XUL to point to
the tor-browser icon set in tor-browser, otherwise torbutton needs to
know about which branding tor-browser was built with. File a new bug for
this?
(11/19/2018 11:19:08 AM) GeKo: sounds good to me
This week:
- file a few Windows bugs related to branding
- file misc other branding-adjacent bugs
- integrate latest assets into the branding pipeline, update
tor-browser-build
igt0:
Last Week:
- More work on #27111 (TBA: about:tor)
- #28093 (TBA: banner)
- #28507 (privacy preferences were not working on TBA)
- [sysrqb: I'm worried this is confusing and we should discuss
this] (GeK: We go with the patch in #28507 for now)
This week:
- Adjustments in the #28093 to make it work on small-ish screens
- More updates to #28507
- More TBA-a2 stuff
GeKo:
Last Week:
-looked a bit at snaps and thought a bit about whether Tor
Browser in the snap store is a good idea or not
-wrote a mail to kinetik about cubeb temp files (#28373) for
further understanding
-thought about our Windows crashes over the weekend when
defining MOZILLA_OFFICIAL. It seems this is due to us using an older
binutils (2.26.1) while 2.27 has the underlying issue fixed; currently
bisecting
-backported a WebExtension API on the weekend for NRL folks
(#27919), need to verify that it works
-review, review, reviews (mostly integrating Tor Browser for
Android into tor-browser-buid, and about:tor related mobile patches)
-worked on #26483 but failed to find the time for writing all of
the pieces. boklm picked this up, thanks! I'll take it from there tomorrow
-wrote patch for #28515 and tested switching from en to en-US
for Torbutton (needed for #25013) (see: #28261)
-meeting about our security slider controls redesign
This Week:
-follow-up snap related email
-try to do the remaining things for #26843 (Fennec localization)
-getting everything reviewed for the alphas
-building releases
sysrqb:
Last week:
- Orbot integration (#28051)
- Commented on TBA and Orbot builds in tor-browser-build (#27977
and #27443)
- TBA+Orbot UI/UX (#28329)
- TBA text selection bug (#27256)
- TBA download failure bug (#27701)
- Looked at TBA localization (#26843)
This week:
- Help finish sisbell with tor-browser-build integration
(however I can help)
- Review and comment on about:tor on Android ticket (#27111)
- Finish investigating localization
- Prep for TBA release
tjr
- have a mingw-clang build of esr60 running.
- Example containing all the patches necessary:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2aff9d1bb5f5d73699ee839c04f529e1ae05536
- Getting build in TC is blocked by:
- the _finite / MATH_DEFINES issue:
https://bugzilla.mozilla.org/show_bug.cgi?id=1508316
- Getting NSS patches backported. (which also blocks the x64
mingw-gcc build)
- Future FYI: I have fxc2 compiling fine with mingw-clang, but
compiling nsis with mingw-clang is very difficult. Haven't solved it yet.
- Eventually, we'll want to fix it; but I figure worst case,
keeping a mingw-gcc toolchain around for a release isn't horrible.
[GeKo: we probably might want to do this anyway to avoid dealing with
mingw-clang related issues popping up in any of the other projects.
Should save us some time and helps with a gradual transition. We had
this for quite a while when transitioning away from GCC to clang for
macOS. It's kind of okay]
- Monthly Mozilla/Tor meeting is tomorrow. Agenda topics include what
meetings for the All Hands we want to have; and hopefully branding study
update.
boklm:
Last week:
- helped with #26843 (Fennec localization)
- worked on testsuite setup (#26149), with tests reports now
published at http://xer3kgd5ygqr7n6i.onion/
- made some plans to go to reproducible builds meeting next month
- started patch for #25143 (Error when building a component that
was already built)
- some reviews
This week:
- fix testsuite issues (#27105 and child tickets)
- test patch for #25143 (Error when building a component that
was already built)
- look at the logs from `-Wl,-t` to try to understand the issue
from #26148
pili:
Last week:
- Reviewed tickets for next release as part of Tor Browser
release meeting
- Sponsor 9 report (not much Tor Browser related work :()
This week:
- More Sponsor 9
- try to finish roadmapping experiments
- Looking forward to the TBA release
antonela:
Last week:
- TB Security Settings
https://trac.torproject.org/projects/tor/ticket/25658 - what else is
needed? (GeKo: Some hint that the NoScript and HTTPS-E icon are not
visible by default anymore on purpose; we should have a less scary
warning when switching the sec slider level as the prefs _are_ applied
without restarting)
- First approach on Design TBA+Orbot configuration UI/UX
https://trac.torproject.org/projects/tor/ticket/28329
This week:
- TBA 2018 Donation banner review.
- More on #28329 -- I invited Fabby, designer at Guardian Project to
the UX meeting tomorrow so we can discuss it.
- Making assets for pospeselr to implement TB icon.
sisbell:
Last week:
- # 27443 Firefox for Android - moved to API 16 for NDK
- # 27977 Integrated Orbot into build
- # 28144 Tor Browser - removed the adding to torbutton (this is now
part of Firefox build)’’
- # 28469 Added Libbacktrace patches for rust
- # 28472 - Added makefile rules for Android builds
This Week:
- Respond and fixes to bug reviews
arthuredelstein
- Last week:
- Finished https://trac.torproject.org/22343 (Save As FPI)
- Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1508355
- Posted patches for Permissions FPI
(https://bugzilla.mozilla.org/show_bug.cgi?id=1330467)
- Worked on optimistic SOCKS
- This week:
- Try to have a working prototype for optimistic SOCKS patch
- Help with next version of banner when text or design is ready
- Whatever administrative tasks needed
- AFK Thursday/Friday.
- AFK some of the following week but will be back on IRC after that.
Georg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.torproject.org/pipermail/tor-project/attachments/20181122/148b0ac4/attachment.sig>
More information about the tor-project
mailing list