[tor-dev] Typo in relay metrics (circs_creared)

Andreas Bollhalder bolle at geodb.org
Mon Jan 9 13:02:06 UTC 2023


Hi Trinity (-1686a)

Thanks a lot for your reply. Nice to see that is was reported already. I've did some web searches, but nothing came up. For the next time, I'll request an account for the GIT repo.

Andreas

On Monday, January 09, 2023 11:40 CET, trinity pointard <trinity.pointard at gmail.com> wrote:
 Hi,

Thanks for reporting this issue. It has already been reported and
fixed recently:
https://gitlab.torproject.org/tpo/core/tor/-/merge_requests/665

> Sorry, at the moment I've no clue what would be the correct way to send patches...

The correct way to send a patch is to open a merge request against
https://gitlab.torproject.org/tpo/core/tor .
To do so you need an account, which you can get by asking on
https://gitlab.onionize.space/.

Regards,
trinity-1686a

On Mon, 9 Jan 2023 at 11:12, Andreas Bollhalder <bolle at geodb.org> wrote:
>
> Hi
>
> I think, there's a typo in the file "src/feature/relay/relay_metrics.c". Shouldn't the word "circs_creared" in the line
>
> metrics_format_label("action", "circs_creared"));
>
> be read as "circs_cleared"?
>
> Andreas
>
> PS:
> Sorry, at the moment I've no clue what would be the correct way to send patches... _______________________________________________
> tor-dev mailing list
> tor-dev at lists.torproject.org
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
_______________________________________________
tor-dev mailing list
tor-dev at lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20230109/2197cab3/attachment.htm>


More information about the tor-dev mailing list