[tor-dev] <unistd.h> in buffers_net.c

teor teor at riseup.net
Thu Jan 10 01:38:33 UTC 2019


Hi,

Thanks for this bug report and patch.

> On 3 Jan 2019, at 13:27, Gisle Vanem <gisle.vanem at gmail.com> wrote:
> 
> Some recent change has added a:
>  #include <unistd.h>
> 
> which fails for MSVC (it doesn't have it).
> 
> Since I fail to find any way to comment on Trac or Gitweb,
> I give notice here. Patching into:
> 
> --- a/src/lib/net/buffers_net.c 2019-01-02 18:57:42
> +++ b/src/lib/net/buffers_net.c 2019-01-03 03:16:32
> @@ -21,7 +21,10 @@
> #endif
> 
> #include <stdlib.h>
> +
> +#ifndef _MSC_VER
> #include <unistd.h>
> +#endif
> 
> #ifdef PARANOIA
> 
> ----------------
> 
> works fine.

We used a slightly different check in:
https://github.com/torproject/tor/commit/4e4f93d364e33bb46e271f3b960a2cf5f38f402e

T

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20190110/67665bb5/attachment-0001.sig>


More information about the tor-dev mailing list