[tor-dev] [RFC] Proposal for the encoding of prop224 onion addresses

David Goulet dgoulet at ev0ke.net
Tue Jan 31 14:38:01 UTC 2017


On 31 Jan (14:26:52), Ivan Markin wrote:
> On Tue, Jan 31, 2017 at 02:54:50PM +0200, George Kadianakis wrote:
> > I merged my prop224 onion encoding patch to torspec just now, after
> > fixing the bug that Ivan mentioned above.
> 
> Thanks!
> 
> btw it's not clear how H() output should be truncated to form a
> checksum. Should it be the first 2 bytes or the last 2 bytes?
> It should be specified in the definition of CHECKSUM (because length of
> digest obviously is not 2 bytes):
> 
> - CHECKSUM = H(".onion checksum" || PUBKEY || VERSION)
> + CHECKSUM = H(".onion checksum" || PUBKEY || VERSION)[:2]

Good point. Current implementation assumes *first two* :). Easy to change but
let's make it clear!

Thanks!
David

> 
> 
> Also it worthwhile to include examples with correct checksums.
> 
> --
> Ivan Markin
> _______________________________________________
> tor-dev mailing list
> tor-dev at lists.torproject.org
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev

-- 
laomWpXMwfgJQSD00XsC6WR0haEh1gK8WeNTaAPQf20=
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 585 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20170131/729ca31c/attachment.sig>


More information about the tor-dev mailing list