[tor-dev] [PATCH] Fix comparison is always true due to limited range of data type

Yawning Angel yawning at schwanenlied.me
Sat Feb 7 03:42:31 UTC 2015


On Thu, 5 Feb 2015 04:02:15 -0800 (PST)
Christian Kujau <lists at nerdbynature.de> wrote:
> Hi,
> I was unable to compile Tor for powerpc32 for a while but I was
> unable to bisect it because of other compilation errors (and "git
> bisect skip" did not help):
> [snip]
> The last good version to compile for me was 
> 4ae729683 ("Try to fix test_checkdir windows compilation more").
> Below is my attempt to fix this issue by declaring "dir" as "signed
> char". It compiles now (4.6.3 and 4.9.1) for powerpc32 and Tor seems
> to work - but please have a look if this is the Right Thing To Do.

Thanks for reporting this.  The bug was fixed in master, and should be
in the next 0.2.6.x-alpha release.  The fix suggested was fine but was
tweaked somewhat when applied

See: https://trac.torproject.org/projects/tor/ticket/14764


Yawning Angel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20150207/cf523b88/attachment.sig>

More information about the tor-dev mailing list