[tor-dev] [PATCH] Log malformed hostnames in socks5 request respecting SafeLogging

Andreas Stieger astieger at suse.com
Tue Aug 25 11:25:11 UTC 2015


On 08/25/2015 08:16 AM, teor wrote:
> On 24 Aug 2015, at 09:12, Andreas Stieger <astieger at suse.com
> <mailto:astieger at suse.com>> wrote:
>> I found a warning-level message in socks5 code relating to malformed
>> hostnames that did not respect the SafeLogging setting, breaking the
>> rule of least surprise. Please review the attached simple patch.
> Thank you for submitting this patch - is there a corresponding Trac ticket?
> (Patches without Trac tickets can get lost easily.)

I created #16891 and attached the patch.


Andreas Stieger <astieger at suse.com>
Project Manager Security
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20150825/8cb2fcf1/attachment.sig>

More information about the tor-dev mailing list