[tor-dev] Call for testing/review: obfsclient

[Yawning Angel]

On Mon, 17 Feb 2014 15:39:07 +0100
Fabian Keil <freebsd-listen at fabiankeil.de> wrote:

> Were you able to build it on your FreeBSD 9.1p10 system using
> gcc?

Not yet, I've been working on adding support for logging.

I will address the GCC build issues when I'm done working on that.  The
system gcc on 9.1p10 is  ancient (4.2.1), and does not support C++11,
so I would have to install gcc from ports.

I have somewhat mixed feelings about working around compiler bugs[0],
but as of this date, gcc 4.7.x is probably still far too common to
not support.  Anything earlier than that start to run into more C++11
compliance problems.

Looking at the rest of the log:

 * 'to_string' is not a member of 'std'

   -> the file needs #include <string>

 * invalid operands of types 'int' and 'void' to binary 'operator!='

   -> OpenSSL changed the function prototypes for the hmac routines.

      The code is correct for modern OpenSSL, but it looks like
      FreeBSD-9.2 ships with 0.9.x.  I'll add a bunch of #ifdefs to do
      the right thing.)

Looking at the patches:

 * Patch 1 tramples over my most recent change to main.cc, will fix
   when merging.

 * Instead of errno.h, cerrno is more appropriate, the constants
   should use the std namespace ones as well, will fix when merging.

Thanks again for the patches,

-- 
Yawning Angel

[0]: [C++11] <:: is incorrectly treated as digraph <: followed by colon
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54526)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20140217/518a21aa/attachment.sig>