[tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.
lunar at torproject.org
Fri Jul 26 09:31:06 UTC 2013
> > Using `git blame` or `git log -S` or `git log -G` will actually work
> > better than a file by file summary. If you throw in the `-M` option,
> > it'll work accross renames, for examples.
> OK. But that information will be lost if we decide to change a VCS for
> some reason.
Well, we could avoid switching to a VCS that would loose such valuable
> > Why not put what you wrote in your description email in there? This was
> > a good explaination of why the change was actually needed! :)
> >> "GHC was recently changed to not allow you to use newtypes in FFI
> >> imports unless the constructor of the newtype is in scope." 
> >>  http://ghc.haskell.org/trac/ghc/ticket/5610
> OK. So let me summarize:
> 1. I shouldn't explicitly name changed functions or modules.
> 2. I can add a small description (like the above) if it's appropriate.
> Did I forget anything?
Feel free to develop your own style and taste. Some readings:
This is quite thorough:
Lunar <lunar at torproject.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the tor-dev