[tor-dev] PRELIMINARY: [PATCH 3/3] Replace 'TorDNSEL.System.Timeout' with 'System.Timeout'.

Nikita Karetnikov nikita at karetnikov.org
Thu Jul 25 23:01:54 UTC 2013

> Using `git blame` or `git log -S` or `git log -G` will actually work
> better than a file by file summary. If you throw in the `-M` option,
> it'll work accross renames, for examples.

OK.  But that information will be lost if we decide to change a VCS for
some reason.

> Why not put what you wrote in your description email in there? This was
> a good explaination of why the change was actually needed! :)

>> "GHC was recently changed to not allow you to use newtypes in FFI
>> imports unless the constructor of the newtype is in scope." [1]
>> [1] http://ghc.haskell.org/trac/ghc/ticket/5610

OK.  So let me summarize:

  1. I shouldn't explicitly name changed functions or modules.

  2. I can add a small description (like the above) if it's appropriate.

Did I forget anything?

> I am looking forward to the moment you'll have a patch set that
> builds.

It won't happen overnight.  Right now I can only build eight modules.
At least sixteen modules need adjustments.  Not very impressive, yep.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20130726/3452749f/attachment.sig>

More information about the tor-dev mailing list