[tor-dev] Tor Browser Launcher

[Micah Lee]

On 02/19/2013 03:29 AM, adrelanos wrote:
> I followed the readme for dependency installing, building and installing
> from the develop branch. Running into two issues trying this...
> 
> LC_ALL and LANG is not set on my system.
> 
> develop ~/torbrowser-launcher/dist/deb_dist $ torbrowser-launcher
> Tor Browser Launcher
> https://github.com/micahflee/torbrowser-launcher
> Traceback (most recent call last):
>   File "/usr/bin/torbrowser-launcher", line 352, in <module>
>     app = TorBrowserLauncher(current_tbb_version)
>   File "/usr/bin/torbrowser-launcher", line 13, in __init__
>     self.discover_arch_lang();
>   File "/usr/bin/torbrowser-launcher", line 65, in discover_arch_lang
>     self.language = locale.getdefaultlocale()[0].replace('_', '-')
> AttributeError: 'NoneType' object has no attribute 'replace'
> 
> Setting them, fixes this. I am not sure how many other people may not
> have these values set, so I think this should be fixed.

Strange. I thought that locale.getdefaultlocale() was supposed to be the
cross-platform method for figuring out the default locale, without the
LANG field.

What operating system are you using? Maybe your getdefaultlocale()
doesn't return a tuple or something. Here's what mine returns -- what
about yours?

[micah at spock] ~$ python
Python 2.7.3 (default, Jan  2 2013, 13:56:14)
[GCC 4.7.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import locale
>>> locale.getdefaultlocale()
('en_US', 'UTF-8')

> Let's set them and try again.
> 
> develop ~/torbrowser-launcher/dist/deb_dist $ export LC_ALL=en_GB.UTF-8
> develop ~/torbrowser-launcher/dist/deb_dist $ export LANG=en_GB.UTF-8
> 
> Running into another issue.
> 
> develop ~/torbrowser-launcher/dist/deb_dist $ torbrowser-launcher
> Tor Browser Launcher
> https://github.com/micahflee/torbrowser-launcher
> Traceback (most recent call last):
>   File "/usr/bin/torbrowser-launcher", line 352, in <module>
>     app = TorBrowserLauncher(current_tbb_version)
>   File "/usr/bin/torbrowser-launcher", line 55, in __init__
>     self.build_ui()
>   File "/usr/bin/torbrowser-launcher", line 124, in build_ui
>     settings.props.gtk_button_images = True
> AttributeError: 'gobject.GProps' object has no attribute 'gtk_button_images'
> develop ~/torbrowser-launcher/dist/deb_dist $
> 
> Am I missing a dependency or?

Yes, sorry I haven't added the dependencies to the debian package yet.
You need python-gtk2.

-- 
Micah Lee
https://twitter.com/micahflee

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20130219/ae3459b5/attachment.pgp>