bug in address family checking?
coderman at gmail.com
Tue Dec 23 00:45:34 UTC 2008
xiando was discussing strange messages in the log of the form:
[warn] tor_addr_is_null(): Bug: Called with unknown address family XXX
where XXX is some unexpected value.
in tracing this down, it always appears after
connection_exit_begin_conn() when the DNS resolve returns immediately
(cached name) and connection_exit_connect() is invoked.
based on the order of calls, it appears that connection_init() is
setting conn->socket_family but is not setting conn->addr.family
(which is what tor_addr_is_null() is looking for).
attached is a very simply patch to set both in connection_init().
however, i do not know enough about Tor internals or the nature of the
IPv6 changes to know if this is the right fix, or if some other cause
is at fault.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 463 bytes
Desc: not available
More information about the tor-dev