[or-cvs] Add rudimentary pthread support that needs more testing.

[Ben Laurie]

Nick Mathewson wrote:
> On Fri, Jan 28, 2005 at 05:37:21AM +0000, Ben Laurie wrote:
> 
>>Nick Mathewson wrote:
>>
>>>Update of /home/or/cvsroot/tor/src/common
>>>In directory moria.mit.edu:/tmp/cvs-serv32238/src/common
>>>
>>>Modified Files:
>>>	compat.c compat.h 
>>>Log Message:
>>>Add rudimentary pthread support that needs more testing.
>>
>>You have two things - HAVE_PTHREAD_H and USE_PTHREADS - does this 
>>indicate that use of pthreads is optional (I ask since under FreeBSD 
>>pthreads are very flaky and generally to be avoided)?
> 
> 
> Good to note.  Is there another threading lib that works on FreeBSD,
> or is this a Don't Do That Then issue?

I am not aware of an alternative. I'm told its better in 5, but I'm not 
sure "better" means "good".

> It could be made optional pretty easy.
> 
> 
>>If not, I strongly advise that you should make them so.
>>
>>BTW, why do threads at all?
> 
> 
> http://bugs.noreply.org/74

You missed "have a worker program that does DNS externally (like ntpd 
does)".

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff