[tor-commits] [Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] fixup! Bug 4234: Use the Firefox Update Process for Base Browser.

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
5661f525 by Pier Angelo Vendrame at 2024-09-02T10:23:38+02:00
fixup! Bug 4234: Use the Firefox Update Process for Base Browser.

Bug 42747: Discard unsupported updates earlier.

Firefox's updater has a function to select updates, which checks mainly
the version number.
Therefore, a more recent update that is unsupported will be chosen over
a compatible one.
We patch this to be able to provide an alternative update path to
Windows 7.

- - - - -


1 changed file:

- toolkit/mozapps/update/UpdateService.sys.mjs


Changes:

=====================================
toolkit/mozapps/update/UpdateService.sys.mjs
=====================================
@@ -3700,18 +3700,20 @@ export class UpdateService {
 
       switch (update.type) {
         case "major":
-          if (!majorUpdate) {
+          if (!majorUpdate || majorUpdate.unsupported) {
             majorUpdate = update;
           } else if (
+            !update.unsupported &&
             vc.compare(majorUpdate.appVersion, update.appVersion) <= 0
           ) {
             majorUpdate = update;
           }
           break;
         case "minor":
-          if (!minorUpdate) {
+          if (!minorUpdate || minorUpdate.unsupported) {
             minorUpdate = update;
           } else if (
+            !update.unsupported &&
             vc.compare(minorUpdate.appVersion, update.appVersion) <= 0
           ) {
             minorUpdate = update;



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5661f525c96f0e3207fe96f14fed73732209651b

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/5661f525c96f0e3207fe96f14fed73732209651b
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20240902/6b7c998d/attachment-0001.htm>