[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] fixup! [android] Modify UI/UX

morgan (@morgan) git at gitlab.torproject.org
Mon Oct 21 19:29:42 UTC 2024



morgan pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
582e1a4b by cypherpunks1 at 2024-10-21T19:20:22+00:00
fixup! [android] Modify UI/UX

Bug 43227: Hide the Firefox Suggest label above search suggestions on Android

- - - - -


1 changed file:

- mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt


Changes:

=====================================
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/search/awesomebar/AwesomeBarView.kt
=====================================
@@ -129,7 +129,7 @@ class AwesomeBarView(
                 components.core.icons,
                 engineForSpeculativeConnects,
                 showEditSuggestion = false,
-                suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//              suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
             )
 
         defaultCombinedHistoryProvider =
@@ -141,7 +141,7 @@ class AwesomeBarView(
                 engine = engineForSpeculativeConnects,
                 maxNumberOfSuggestions = METADATA_SUGGESTION_LIMIT,
                 showEditSuggestion = false,
-                suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//              suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
             )
 
         val searchBitmap = getDrawable(activity, R.drawable.ic_search)!!.apply {
@@ -346,7 +346,7 @@ class AwesomeBarView(
                     loadUrlUseCase = loadUrlUseCase,
                     includeSponsoredSuggestions = state.showSponsoredSuggestions,
                     includeNonSponsoredSuggestions = state.showNonSponsoredSuggestions,
-                    suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//                  suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
                     contextId = activity.settings().contileContextId,
                 ),
             )
@@ -379,7 +379,7 @@ class AwesomeBarView(
                     engine = engineForSpeculativeConnects,
                     maxNumberOfSuggestions = METADATA_SUGGESTION_LIMIT,
                     showEditSuggestion = false,
-                    suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//                  suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
                     resultsUriFilter = filter::shouldIncludeUri,
                 )
             } else {
@@ -394,7 +394,7 @@ class AwesomeBarView(
                     engine = engineForSpeculativeConnects,
                     maxNumberOfSuggestions = METADATA_SUGGESTION_LIMIT,
                     showEditSuggestion = false,
-                    suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//                  suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
                     resultsUriFilter = filter::shouldIncludeUri,
                 )
             } else {
@@ -498,7 +498,7 @@ class AwesomeBarView(
                 getDrawable(activity, R.drawable.ic_search_results_device_mobile),
                 getDrawable(activity, R.drawable.ic_search_results_device_tablet),
             ),
-            suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//          suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
             resultsUrlFilter = filter?.let { it::shouldIncludeUrl },
         )
     }
@@ -521,7 +521,7 @@ class AwesomeBarView(
             components.core.icons,
             getDrawable(activity, R.drawable.ic_search_results_tab),
             excludeSelectedSession = !fromHomeFragment,
-            suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//          suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
             resultsUriFilter = filter?.let { it::shouldIncludeUri },
         )
     }
@@ -544,7 +544,7 @@ class AwesomeBarView(
             indicatorIcon = getDrawable(activity, R.drawable.ic_search_results_bookmarks),
             engine = engineForSpeculativeConnects,
             showEditSuggestion = false,
-            suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
+//          suggestionsHeader = activity.getString(R.string.firefox_suggest_header),
             resultsUriFilter = filter?.let { it::shouldIncludeUri },
         )
     }



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/582e1a4b7061eb993e7f42fc1fae4d49d0864ccd

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/582e1a4b7061eb993e7f42fc1fae4d49d0864ccd
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20241021/3d7402f7/attachment-0001.htm>


More information about the tor-commits mailing list