[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-128.3.0esr-14.0-1] Bug 43196: Remove the vendor name from media notifications on Linux.

[morgan (@morgan)]

morgan pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
d586e4a6 by Pier Angelo Vendrame at 2024-10-08T20:09:43+00:00
Bug 43196: Remove the vendor name from media notifications on Linux.

Firefox shows "vendor remoteName" as a title of the "... is playing
media" notification on Linux.
However, for our browser the remote name is enough, and prepending the
vendor to it creates a string users usually never see.

- - - - -


1 changed file:

- widget/gtk/MPRISServiceHandler.cpp


Changes:

=====================================
widget/gtk/MPRISServiceHandler.cpp
=====================================
@@ -414,8 +414,10 @@ void MPRISServiceHandler::InitIdentity() {
       do_GetService("@mozilla.org/xre/app-info;1", &rv);
   MOZ_ASSERT(NS_SUCCEEDED(rv));
 
+#ifndef BASE_BROWSER_VERSION
   rv = appInfo->GetVendor(mIdentity);
   MOZ_ASSERT(NS_SUCCEEDED(rv));
+#endif
 
   if (gAppData) {
     mDesktopEntry = gAppData->remotingName;
@@ -424,7 +426,9 @@ void MPRISServiceHandler::InitIdentity() {
     MOZ_ASSERT(NS_SUCCEEDED(rv));
   }
 
+#ifndef BASE_BROWSER_VERSION
   mIdentity.Append(' ');
+#endif
   mIdentity.Append(mDesktopEntry);
 
   // Compute the desktop entry name like nsAppRunner does for g_set_prgname



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d586e4a69e5853da427b7b8ca4debf24d1e315c3

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/d586e4a69e5853da427b7b8ca4debf24d1e315c3
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20241008/1587248b/attachment-0001.htm>