[tor-commits] [Git][tpo/applications/tor-browser-build][main] Bug 41256: Re-generate update-responses in upload-update_responses-to-staticiforme

[morgan (@morgan)]

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build


Commits:
3f075f68 by Nicolas Vigier at 2024-10-03T18:09:53+00:00
Bug 41256: Re-generate update-responses in upload-update_responses-to-staticiforme

The script was not re-generating update-responses if it had been
generated before. In some case this can be a problem:
https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/41245#note_3088148

- - - - -


1 changed file:

- tools/signing/upload-update_responses-to-staticiforme


Changes:

=====================================
tools/signing/upload-update_responses-to-staticiforme
=====================================
@@ -8,15 +8,12 @@ check_torbrowser_version_var
 
 update_responses_tar_filename="update-responses-$tbb_version_type-$tbb_version.tar"
 update_responses_tar="$script_dir/../../$SIGNING_PROJECTNAME/$tbb_version_type/update-responses/$update_responses_tar_filename"
-if test -f "$update_responses_tar"
-then
-  echo "$update_responses_tar_filename already exists: not running 'make $SIGNING_PROJECTNAME-update_responses-$tbb_version_type'"
-else
-  echo "Running 'make $SIGNING_PROJECTNAME-update_responses-$tbb_version_type'"
-  pushd "$script_dir/../.." > /dev/null
-  make $SIGNING_PROJECTNAME-update_responses-$tbb_version_type
-  popd > /dev/null
-fi
+test -f "$update_responses_tar" && \
+  echo "warning: $update_responses_tar_filename already exists. It will be re-generated."
+echo "Running 'make $SIGNING_PROJECTNAME-update_responses-$tbb_version_type'"
+pushd "$script_dir/../.." > /dev/null
+make $SIGNING_PROJECTNAME-update_responses-$tbb_version_type
+popd > /dev/null
 
 cd $update_responses_repository_dir
 git checkout main



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3f075f68bb694a8df31bbb5ccfae04df929deb15

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/3f075f68bb694a8df31bbb5ccfae04df929deb15
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20241003/fd9f594f/attachment-0001.htm>