[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-115.15.0esr-13.5-2] Bug 1909099 - Always clean up old session restore and sync log files....

[ma1 (@ma1)]

ma1 pushed to branch tor-browser-115.15.0esr-13.5-2 at The Tor Project / Applications / Tor Browser


Commits:
699a06bf by Sam Foster at 2024-08-31T13:05:09+08:00
Bug 1909099 - Always clean up old session restore and sync log files. r=markh,sessionstore-reviewers,dao

Differential Revision: https://phabricator.services.mozilla.com/D217520
- - - - -


1 changed file:

- services/common/logmanager.sys.mjs


Changes:

=====================================
services/common/logmanager.sys.mjs
=====================================
@@ -363,12 +363,7 @@ LogManager.prototype = {
         filename,
         this._log
       );
-      // It's not completely clear to markh why we only do log cleanups
-      // for errors, but for now the Sync semantics have been copied...
-      // (one theory is that only cleaning up on error makes it less
-      // likely old error logs would be removed, but that's not true if
-      // there are occasional errors - let's address this later!)
-      if (reason == this.ERROR_LOG_WRITTEN && !this._cleaningUpFileLogs) {
+      if (!this._cleaningUpFileLogs) {
         this._log.trace("Running cleanup.");
         try {
           await this.cleanupLogs();



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/699a06bfa22ad09e8c8bd01c7de1d4adec356346

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/699a06bfa22ad09e8c8bd01c7de1d4adec356346
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20240831/5886a73f/attachment-0001.htm>