[tor-commits] [Git][tpo/applications/tor-browser][base-browser-128.2.0esr-14.0-1] 2 commits: fixup! Bug 41568: Disable LaterRun

[Pier Angelo Vendrame (@pierov)]

Pier Angelo Vendrame pushed to branch base-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
44820468 by Henry Wilkes at 2024-08-29T16:42:37+02:00
fixup! Bug 41568: Disable LaterRun

Bug 42630: Revert patch.

- - - - -
d44ef5f7 by Henry Wilkes at 2024-08-29T16:42:41+02:00
Bug 42630: Disable LaterRun module.

- - - - -


2 changed files:

- browser/components/BrowserContentHandler.sys.mjs
- browser/modules/LaterRun.sys.mjs


Changes:

=====================================
browser/components/BrowserContentHandler.sys.mjs
=====================================
@@ -757,8 +757,8 @@ nsBrowserContentHandler.prototype = {
             additionalPage = Services.urlFormatter.formatURLPref(
               "startup.homepage_welcome_url.additional"
             );
-            // Disable 'later run' pages for new profiles (tor-browser#41568)
-            lazy.LaterRun.selfDestruct();
+            // Turn on 'later run' pages for new profiles.
+            lazy.LaterRun.enable(lazy.LaterRun.ENABLE_REASON_NEW_PROFILE);
             break;
           case OVERRIDE_NEW_MSTONE: {
             // Check whether we will restore a session. If we will, we assume


=====================================
browser/modules/LaterRun.sys.mjs
=====================================
@@ -61,6 +61,20 @@ export let LaterRun = {
   },
 
   init(reason) {
+    // Keep disabled in Base Browser. See tor-browser#41568.
+    // NOTE: This means that users cannot benefit from feature prompts gated
+    // behind LaterRun.
+    // In mozilla ESR 128 it is only used in one place, and is gated behind a
+    // feature recommendation preference that we switch off in Base Browser
+    // anyway. See tor-browser#42630.
+    // But this decision should be reviewed. See tor-browser#43093.
+    Services.prefs.setBoolPref(kEnabledPref, false);
+    // Clear any preferences that may have been set before LaterRun was
+    // disabled.
+    Services.prefs.clearUserPref(kSessionCountPref);
+    Services.prefs.clearUserPref(kProfileCreationTime);
+    Services.prefs.clearUserPref(kUpdateAppliedTime);
+
     if (!this.enabled) {
       return;
     }
@@ -99,11 +113,8 @@ export let LaterRun = {
     return Services.prefs.getBoolPref(kEnabledPref, false);
   },
 
-  enable(reason) {
-    if (!this.enabled) {
-      Services.prefs.setBoolPref(kEnabledPref, true);
-      this.init(reason);
-    }
+  enable(_reason) {
+    // Keep disabled in Base Browser. See tor-browser#41568.
   },
 
   get hoursSinceInstall() {



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fe2c105ebe5b22859013a26fa1a516e49cbd507...d44ef5f7ce842d279635e7940f55ed6ad7153a7f

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fe2c105ebe5b22859013a26fa1a516e49cbd507...d44ef5f7ce842d279635e7940f55ed6ad7153a7f
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20240829/4b772f5d/attachment-0001.htm>