[tor-commits] [Git][tpo/applications/tor-browser][tor-browser-128.2.0esr-14.0-1] fixup! [android] Disable features and functionality

[morgan (@morgan)]

morgan pushed to branch tor-browser-128.2.0esr-14.0-1 at The Tor Project / Applications / Tor Browser


Commits:
47a49a9d by Morgan at 2024-08-29T00:25:07+00:00
fixup! [android] Disable features and functionality

Bug 43094: Remove 'Open in regular tab' button

- - - - -


1 changed file:

- mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt


Changes:

=====================================
mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
=====================================
@@ -265,12 +265,12 @@ open class DefaultToolbarMenu(
         onItemTapped.invoke(ToolbarMenu.Item.RequestDesktop(checked))
     }
 
-    private val openInRegularTabItem = BrowserMenuImageText(
-        label = context.getString(R.string.browser_menu_open_in_regular_tab),
-        imageResource = R.drawable.ic_open_in_regular_tab,
-    ) {
-        onItemTapped.invoke(ToolbarMenu.Item.OpenInRegularTab)
-    }
+//  private val openInRegularTabItem = BrowserMenuImageText(
+//      label = context.getString(R.string.browser_menu_open_in_regular_tab),
+//      imageResource = R.drawable.ic_open_in_regular_tab,
+//  ) {
+//      onItemTapped.invoke(ToolbarMenu.Item.OpenInRegularTab)
+//  }
 
     private val customizeReaderView = BrowserMenuImageText(
         label = context.getString(R.string.browser_menu_customize_reader_view),
@@ -419,7 +419,7 @@ open class DefaultToolbarMenu(
                 findInPageItem,
                 translationsItem.apply { visible = ::shouldShowTranslations },
                 desktopSiteItem,
-                openInRegularTabItem.apply { visible = ::shouldShowOpenInRegularTab },
+                // openInRegularTabItem.apply { visible = ::shouldShowOpenInRegularTab },
                 customizeReaderView.apply { visible = ::shouldShowReaderViewCustomization },
                 // openInApp.apply { visible = ::sho uldShowOpenInApp },
                 // reportSiteIssuePlaceholder,



View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47a49a9dfbe017b0257d6992eb372b6611f7d202

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47a49a9dfbe017b0257d6992eb372b6611f7d202
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20240829/71e03b46/attachment-0001.htm>