[tor-commits] [tor] branch main updated: crypto: Clarifying comment for the random hostname calculation

gitolite role git at cupani.torproject.org
Tue Mar 15 18:10:14 UTC 2022


This is an automated email from the git hooks/post-receive script.

dgoulet pushed a commit to branch main
in repository tor.

The following commit(s) were added to refs/heads/main by this push:
     new cf93d35209 crypto: Clarifying comment for the random hostname calculation
cf93d35209 is described below

commit cf93d352095d252baf4cba07e51cb9a84ef8d9de
Author: David Goulet <dgoulet at torproject.org>
AuthorDate: Tue Mar 15 14:00:00 2022 -0400

    crypto: Clarifying comment for the random hostname calculation
    
    Closes #40520
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 src/lib/crypt_ops/crypto_rand.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/lib/crypt_ops/crypto_rand.c b/src/lib/crypt_ops/crypto_rand.c
index 5bf3a65b3b..f39ee6c24f 100644
--- a/src/lib/crypt_ops/crypto_rand.c
+++ b/src/lib/crypt_ops/crypto_rand.c
@@ -568,6 +568,8 @@ crypto_random_hostname(int min_rand_len, int max_rand_len, const char *prefix,
   prefixlen = strlen(prefix);
   resultlen = prefixlen + strlen(suffix) + randlen + 16;
 
+  /* (x+(n-1))/n is an idiom for dividing x by n, rounding up to the nearest
+   * integer and thus why this construction. */
   rand_bytes_len = ((randlen*5)+7)/8;
   if (rand_bytes_len % 5)
     rand_bytes_len += 5 - (rand_bytes_len%5);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the tor-commits mailing list