[tor-commits] [tor-browser] 20/34: Bug 1762125. Allow DXVA on newer Intel drivers. r=aosmond a=a=dsmith

[gitolite role]

This is an automated email from the git hooks/post-receive script.

richard pushed a commit to branch tor-browser-91.9esr-11.0-1
in repository tor-browser.

commit 405e75b662d6977d5d319ae16b5c24534236555f
Author: Jeff Muizelaar <jmuizelaar at mozilla.com>
AuthorDate: Mon Apr 11 12:42:24 2022 +0000

    Bug 1762125. Allow DXVA on newer Intel drivers. r=aosmond a=a=dsmith
    
    Newer Intel drivers break our assumptions about the bottom four digits
    being the build id and we end up blocking newer drivers with build ids
    like 11404. This reverts the change in bug 1295902 which changed this
    blocklist rule to only look at the build number. I think bug 1295902 was
    just trying to be more correct and I don't know that it actually blocks
    important crashes. Decoding now mostly happens in the GPU process
    so the impact of these crashes is reduced from what it originally was.
    
    The information on how to interpret Intel driver version is from:
    https://www.intel.ca/content/www/ca/en/support/articles/000005654/graphics.html
    
    The proper fix is to have Intel specific driver version parsing.
    
    This is a more conservative fix that also adds blocking for drivers
    earlier or equal to 8.15.10.2849.
    
    Differential Revision: https://phabricator.services.mozilla.com/D143362
---
 widget/windows/GfxInfo.cpp | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/widget/windows/GfxInfo.cpp b/widget/windows/GfxInfo.cpp
index 6a58c9a71d6f4..cbf42c810092c 100644
--- a/widget/windows/GfxInfo.cpp
+++ b/widget/windows/GfxInfo.cpp
@@ -1686,12 +1686,18 @@ const nsTArray<GfxDriverInfo>& GfxInfo::GetGfxDriverInfo() {
         V(8, 15, 10, 2869), "FEATURE_FAILURE_INTEL_W7_HW_DECODING");
 
     /* Bug 1203199/1092166: DXVA startup crashes on some intel drivers. */
-    APPEND_TO_DRIVER_BLOCKLIST(OperatingSystem::Windows, DeviceFamily::IntelAll,
-                               nsIGfxInfo::FEATURE_HARDWARE_VIDEO_DECODING,
-                               nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
-                               DRIVER_BUILD_ID_LESS_THAN_OR_EQUAL, 2849,
-                               "FEATURE_FAILURE_BUG_1203199_1",
-                               "Intel driver > X.X.X.2849");
+    APPEND_TO_DRIVER_BLOCKLIST_RANGE(OperatingSystem::Windows, DeviceFamily::IntelAll,
+        nsIGfxInfo::FEATURE_HARDWARE_VIDEO_DECODING,
+        nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
+        DRIVER_BETWEEN_INCLUSIVE, V(9,17,10,0), V(9,17,10,2849),
+        "FEATURE_FAILURE_BUG_1203199_1", "Intel driver > 9.17.10.2849");
+
+    /* Bug 1203199/1092166: DXVA startup crashes on some intel drivers. */
+    APPEND_TO_DRIVER_BLOCKLIST_RANGE(OperatingSystem::Windows, DeviceFamily::IntelAll,
+        nsIGfxInfo::FEATURE_HARDWARE_VIDEO_DECODING,
+        nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
+        DRIVER_BETWEEN_INCLUSIVE, V(8,15,10,0), V(8,15,10,2849),
+        "FEATURE_FAILURE_BUG_1203199_1", "Intel driver > 8.15.10.2849");
 
     APPEND_TO_DRIVER_BLOCKLIST2(
         OperatingSystem::Windows, DeviceFamily::Nvidia8800GTS,

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.