[tor-commits] [tor/main] relay: Comment out a unused variable for now

dgoulet at torproject.org dgoulet at torproject.org
Wed Oct 20 20:00:09 UTC 2021


commit 7c2c749d8987d675bfe0a74100c2da5f693037c0
Author: David Goulet <dgoulet at torproject.org>
Date:   Wed Oct 20 15:17:06 2021 -0400

    relay: Comment out a unused variable for now
    
    We keep it around until libevent is fixed, it should be used again. In
    the meantime, avoid the compiler to complain of this unused variable.
    
    https://gitlab.torproject.org/dgoulet/tor/-/jobs/43358#L1522
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 src/feature/relay/relay_metrics.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/feature/relay/relay_metrics.c b/src/feature/relay/relay_metrics.c
index 5f1238a5d3..0886b6ae87 100644
--- a/src/feature/relay/relay_metrics.c
+++ b/src/feature/relay/relay_metrics.c
@@ -124,6 +124,8 @@ fill_tcp_exhaustion_values(void)
   metrics_store_entry_update(sentry, rep_hist_get_n_tcp_exhaustion());
 }
 
+/* NOTE: Disable the record type label until libevent is fixed. */
+#if 0
 /** Helper array containing mapping for the name of the different DNS records
  * and their corresponding libevent values. */
 static struct dns_type {
@@ -135,6 +137,7 @@ static struct dns_type {
   { .name = "AAAA", .type = DNS_IPv6_AAAA  },
 };
 static const size_t num_dns_types = ARRAY_LENGTH(dns_types);
+#endif
 
 /** Fill function for the RELAY_METRICS_NUM_DNS_ERRORS metrics. */
 static void
@@ -166,7 +169,6 @@ fill_dns_error_values(void)
   static const size_t num_errors = ARRAY_LENGTH(errors);
 
   /* NOTE: Disable the record type label until libevent is fixed. */
-  (void) num_dns_types;
 #if 0
   for (size_t i = 0; i < num_dns_types; i++) {
     /* Dup the label because metrics_format_label() returns a pointer to a



More information about the tor-commits mailing list