[tor-commits] [snowflake-webext/main] No need to set DtlsSrtpKeyAgreement option

arlo at torproject.org arlo at torproject.org
Wed Nov 3 18:39:56 UTC 2021


commit 66b67687bcfd0e15222ebb930188101ff49212de
Author: Arlo Breault <arlolra at gmail.com>
Date:   Wed Nov 3 12:46:27 2021 -0400

    No need to set DtlsSrtpKeyAgreement option
    
    This used to be required for Chrome and Firefox to interoperate a long
    time but is deprecated and being removed,
    https://bugs.chromium.org/p/chromium/issues/detail?id=804275
    
    Chrome was complaining,
    "The constraint "DtlsSrtpKeyAgreement" will be removed. You have
    specified a "true" value for this constraint, which has no effect, but
    you can remove this constraint for tidiness."
---
 proxypair.js | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/proxypair.js b/proxypair.js
index 0ad4a33..93efd5a 100644
--- a/proxypair.js
+++ b/proxypair.js
@@ -35,13 +35,7 @@ class ProxyPair {
 
   // Prepare a WebRTC PeerConnection and await for an SDP offer.
   begin() {
-    this.pc = new RTCPeerConnection(this.pcConfig, {
-      optional: [
-        {
-          DtlsSrtpKeyAgreement: true
-        },
-      ]
-    });
+    this.pc = new RTCPeerConnection(this.pcConfig);
     this.pc.onicecandidate = (evt) => {
       // Browser sends a null candidate once the ICE gathering completes.
       if (null === evt.candidate && this.pc.connectionState !== 'closed') {





More information about the tor-commits mailing list