[tor-commits] [tor/master] Stop calling evdns_set_random_bytes_fn()

ahf at torproject.org ahf at torproject.org
Mon May 10 10:59:38 UTC 2021


commit f20f5a4e376d254e069fed66a321bc9cdd537096
Author: Nick Mathewson <nickm at torproject.org>
Date:   Fri Apr 16 17:26:59 2021 -0400

    Stop calling evdns_set_random_bytes_fn()
    
    This function has been a no-op since Libevent 2.0.4-alpha, when
    libevent got an arc4random() implementation.  Libevent has finally
    removed it, which will break our compilation unless we stop calling
    it.  (This is currently breaking compilation in OSS-fuzz.)
    
    Closes #40371.
---
 changes/bug40371        | 6 ++++++
 src/feature/relay/dns.c | 1 -
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/changes/bug40371 b/changes/bug40371
new file mode 100644
index 0000000000..8cc7117f9f
--- /dev/null
+++ b/changes/bug40371
@@ -0,0 +1,6 @@
+  o Minor bugfixes (compatibility):
+    - Fix compatibility with the most recent Libevent versions, which
+      no longer have an evdns_set_random_bytes() function.  Because
+      this function has been a no-op since Libevent 2.0.4-alpha,
+      it is safe for us to just stop calling it.  Fixes bug 40371;
+      bugfix on 0.2.1.7-alpha.
diff --git a/src/feature/relay/dns.c b/src/feature/relay/dns.c
index e20a39482f..075d7d7063 100644
--- a/src/feature/relay/dns.c
+++ b/src/feature/relay/dns.c
@@ -224,7 +224,6 @@ int
 dns_init(void)
 {
   init_cache_map();
-  evdns_set_random_bytes_fn(dns_randfn_);
   if (server_mode(get_options())) {
     int r = configure_nameservers(1);
     return r;





More information about the tor-commits mailing list