[tor-commits] [tor/release-0.4.4] Fix underflow in rend_cache/free_all test.

dgoulet at torproject.org dgoulet at torproject.org
Fri Sep 18 13:46:04 UTC 2020


commit 7945e075a42aecaa633565ebbc5d3b809ed24e7e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Thu Sep 17 14:04:54 2020 -0400

    Fix underflow in rend_cache/free_all test.
    
    We already fixed these in #40099 and #40125.
    
    This patch fixes #40126.  Bugfix on 0.2.8.1-alpha.
---
 changes/ticket40126       | 4 ++++
 src/test/test_rendcache.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/changes/ticket40126 b/changes/ticket40126
new file mode 100644
index 0000000000..1f5806e6cb
--- /dev/null
+++ b/changes/ticket40126
@@ -0,0 +1,4 @@
+  o Testing (onion service v2):
+    - Fix another rendezvous cache unit test that was triggering an underflow on the
+      global rend cache allocation. Fixes bug 40126; bugfix on
+      0.2.8.1-alpha.
diff --git a/src/test/test_rendcache.c b/src/test/test_rendcache.c
index 92e135f3b1..8b0e2df485 100644
--- a/src/test/test_rendcache.c
+++ b/src/test/test_rendcache.c
@@ -954,6 +954,7 @@ test_rend_cache_free_all(void *data)
   one->parsed = desc_one;
   desc_one->timestamp = time(NULL) + TIME_IN_THE_PAST;
   desc_one->pk = pk_generate(0);
+  rend_cache_increment_allocation(rend_cache_entry_allocation(one));
   strmap_set_lc(rend_cache, "foo1", one);
 
   rend_cache_free_all();





More information about the tor-commits mailing list