[tor-commits] [Git][tpo/applications/fenix][tor-browser-82.0.0b4-10.0-1] 2 commits: fixup! Bug 40028: Implement new home screen

[Matthew Finkel]

Matthew Finkel pushed to branch tor-browser-82.0.0b4-10.0-1 at The Tor Project / Applications / fenix


Commits:
4666fc3c by Alex Catarineu at 2020-10-19T16:56:35+02:00
fixup! Bug 40028: Implement new home screen

Fixes #40076: "Explore privately" not visible entirely in French

- - - - -
5b768f33 by Matthew Finkel at 2020-10-19T20:01:47+00:00
Merge remote-tracking branch 'acatgl/40076' into tor-browser-82.0.0b4-10.0-1

- - - - -


2 changed files:

- app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
- app/src/main/res/layout/fragment_home.xml


Changes:

=====================================
app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
=====================================
@@ -192,6 +192,15 @@ class HomeFragment : Fragment() {
         val activity = activity as HomeActivity
         val components = requireComponents
 
+        // Splits by full stops or commas and puts the parts in different lines.
+        // Ignoring separators at the end of the string, it is expected
+        // that there are at most two parts (e.g. "Explore. Privately.")..
+        view.exploreprivately.text = view
+            .exploreprivately
+            .text
+            ?.replace(" *([.,。।]) *".toRegex(), "$1\n")
+            ?.trim()
+
         currentMode = CurrentMode(
             view.context,
             onboarding,


=====================================
app/src/main/res/layout/fragment_home.xml
=====================================
@@ -84,8 +84,7 @@
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             android:layout_gravity="center|center_vertical"
-            android:width="199dp"
-            android:height="110dp"
+            android:gravity="center_horizontal"
             android:clickable="false"
             android:ellipsize="end"
             android:focusable="false"



View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/77e2f0c7b28c541a0985b8cd3fdfb155c554e7c8...5b768f331552b913bfd62729e4e183d986277f8b

-- 
View it on GitLab: https://gitlab.torproject.org/tpo/applications/fenix/-/compare/77e2f0c7b28c541a0985b8cd3fdfb155c554e7c8...5b768f331552b913bfd62729e4e183d986277f8b
You're receiving this email because of your account on gitlab.torproject.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.torproject.org/pipermail/tor-commits/attachments/20201019/20803401/attachment-0001.htm>