[tor-commits] [tor/master] Update the list of recommended protocol versions to match >=0.3.5.

[dgoulet at torproject.org]

commit b67f7d722d4cb94d1e77ff9b300c82d8c72b14c3
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Jun 17 11:00:58 2020 -0400

    Update the list of recommended protocol versions to match >=0.3.5.
    
    Since Tor 0.2.9 has been unsupported since January, 0.3.5 is the
    oldest supported version, and its features constitute the oldest
    recommended feature-set.
    
    This patch updates these recommendations:
    
       DirCache=2
    
          Support for consensus diffs.
          New in 0.3.1.1-alpha.
    
       HSDir=2
    
          Support for v3 onion service descriptors.
          New in 0.3.0.4-alpha.
    
       HSIntro=4
    
          Support for Ed25519 intropoint authentication keys.
          New in 0.3.0-4-alpha.
    
       HSRend=2
    
          Support for rendezvous cells longer than 20 bytes.
          New in 0.2.9.4-alpha.
    
       Link=5
    
          Link padding and link padding negotiation.
          New in 0.3.3.2-alpha.
    
       LinkAuth=3
    
           Ed25519 link authentication.
           New in 0.3.0.1-alpha.
---
 changes/ticket32696           | 7 +++++++
 src/feature/dirauth/dirvote.h | 8 ++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/changes/ticket32696 b/changes/ticket32696
new file mode 100644
index 000000000..8f56fc394
--- /dev/null
+++ b/changes/ticket32696
@@ -0,0 +1,7 @@
+  o Minor features (directory authority):
+    - Authorities now recommend protocol versions that are supported
+      by Tor 0.3.5 and later. (Earlier versions of Tor have been
+      deprecated since January of this year.)  This recommendation
+      will cause older clients and relays to give a warning on startup,
+      or when they download a consensus directory.
+      Closes ticket 32696.
diff --git a/src/feature/dirauth/dirvote.h b/src/feature/dirauth/dirvote.h
index cf70e1184..1b1c9f2cc 100644
--- a/src/feature/dirauth/dirvote.h
+++ b/src/feature/dirauth/dirvote.h
@@ -239,14 +239,14 @@ STATIC microdesc_t *dirvote_create_microdescriptor(const routerinfo_t *ri,
  * Recommending a new protocol causes old tor versions to log a warning.
  */
 #define DIRVOTE_RECOMMEND_RELAY_PROTO \
-  "Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1 " \
-  "Link=4 Microdesc=1-2 Relay=2"
+  "Cons=1-2 Desc=1-2 DirCache=2 HSDir=2 HSIntro=4 HSRend=2 " \
+  "Link=5 LinkAuth=3 Microdesc=1-2 Relay=2"
 /** The recommended client protocols for this authority's votes.
  * Recommending a new protocol causes old tor versions to log a warning.
  */
 #define DIRVOTE_RECOMMEND_CLIENT_PROTO \
-  "Cons=1-2 Desc=1-2 DirCache=1 HSDir=1 HSIntro=3 HSRend=1 " \
-  "Link=4 Microdesc=1-2 Relay=2"
+  "Cons=1-2 Desc=1-2 DirCache=2 HSDir=2 HSIntro=4 HSRend=2 " \
+  "Link=5 LinkAuth=3 Microdesc=1-2 Relay=2"
 
 /** The required relay protocols for this authority's votes.
  * WARNING: Requiring a new protocol causes old tor versions to shut down.