[tor-commits] [stem/master] Bad endpoint type within test

atagar at torproject.org atagar at torproject.org
Wed Jul 22 01:51:23 UTC 2020


commit a65a4777727c9941ab533c219d854d80b5149d1c
Author: Damian Johnson <atagar at torproject.org>
Date:   Tue Jul 21 18:12:33 2020 -0700

    Bad endpoint type within test
    
    Stem 2.x dropped support for tuple endpoints. Guess I haven't run our ONLINE
    test target since then...
    
      ======================================================================
      ERROR: test_using_authorities
      ----------------------------------------------------------------------
      Traceback (most recent call last):
        File "/home/atagar/Desktop/stem/test/require.py", line 60, in wrapped
          return func(self, *args, **kwargs)
        File "/home/atagar/Desktop/stem/test/require.py", line 75, in wrapped
          return func(self, *args, **kwargs)
        File "/home/atagar/Desktop/stem/test/integ/descriptor/remote.py", line 113, in test_using_authorities
          validate = True,
        File "/home/atagar/Desktop/stem/stem/descriptor/remote.py", line 408, in __init__
          raise ValueError("Endpoints must be an stem.ORPort or stem.DirPort. '%s' is a %s." % (endpoint, type(endpoint).__name__))
      ValueError: Endpoints must be an stem.ORPort or stem.DirPort. '('128.31.0.39', 9131)' is a tuple.
---
 test/integ/descriptor/remote.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/integ/descriptor/remote.py b/test/integ/descriptor/remote.py
index 5788f322..319800f5 100644
--- a/test/integ/descriptor/remote.py
+++ b/test/integ/descriptor/remote.py
@@ -108,7 +108,7 @@ class TestDescriptorDownloader(unittest.TestCase):
       queries.append((stem.descriptor.remote.Query(
         '/tor/server/fp/9695DFC35FFEB861329B9F1AB04C46397020CE31',
         'server-descriptor 1.0',
-        endpoints = [(authority.address, authority.dir_port)],
+        endpoints = [stem.DirPort(authority.address, authority.dir_port)],
         timeout = 30,
         validate = True,
       ), authority))





More information about the tor-commits mailing list