[tor-commits] [tor/master] Fix coccinelle complaint in test-memwipe.c

[asn at torproject.org]

commit 2aa5e95f58d70ab1ab610ddbfe72da460f35be09
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Jul 6 15:18:28 2020 -0400

    Fix coccinelle complaint in test-memwipe.c
---
 src/test/test-memwipe.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/test/test-memwipe.c b/src/test/test-memwipe.c
index 4faf7bc5a..5e4cc7678 100644
--- a/src/test/test-memwipe.c
+++ b/src/test/test-memwipe.c
@@ -30,8 +30,8 @@ const char *s = NULL;
 #define BUF_LEN 2048
 
 #define FILL_BUFFER_IMPL()                                              \
+  do {                                                                  \
   unsigned int i;                                                       \
-  unsigned sum = 0;                                                     \
                                                                         \
   /* Fill up a 1k buffer with a recognizable pattern. */                \
   for (i = 0; i < BUF_LEN; i += strlen(s)) {                            \
@@ -42,7 +42,8 @@ const char *s = NULL;
   /* optimized away. */                                                 \
   for (i = 0; i < BUF_LEN; ++i) {                                       \
     sum += (unsigned char)buf[i];                                       \
-  }
+  }                                                                     \
+  } while (0)
 
 #ifdef OpenBSD
 /* Disable some of OpenBSD's malloc protections for this test. This helps
@@ -55,7 +56,8 @@ static unsigned
 fill_a_buffer_memset(void)
 {
   char buf[BUF_LEN];
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   memset(buf, 0, sizeof(buf));
   return sum;
 }
@@ -64,7 +66,8 @@ static unsigned
 fill_a_buffer_memwipe(void)
 {
   char buf[BUF_LEN];
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   memwipe(buf, 0, sizeof(buf));
   return sum;
 }
@@ -73,7 +76,8 @@ static unsigned
 fill_a_buffer_nothing(void)
 {
   char buf[BUF_LEN];
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   return sum;
 }
 
@@ -116,7 +120,8 @@ static unsigned
 fill_heap_buffer_memset(void)
 {
   char *buf = heap_buf = raw_malloc(BUF_LEN);
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   memset(buf, 0, BUF_LEN);
   raw_free(buf);
   return sum;
@@ -126,7 +131,8 @@ static unsigned
 fill_heap_buffer_memwipe(void)
 {
   char *buf = heap_buf = raw_malloc(BUF_LEN);
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   memwipe(buf, 0, BUF_LEN);
   raw_free(buf);
   return sum;
@@ -136,7 +142,8 @@ static unsigned
 fill_heap_buffer_nothing(void)
 {
   char *buf = heap_buf = raw_malloc(BUF_LEN);
-  FILL_BUFFER_IMPL()
+  unsigned sum = 0;
+  FILL_BUFFER_IMPL();
   raw_free(buf);
   return sum;
 }