[tor-commits] [snowflake/master] Remove client test with nil broker

dcf at torproject.org dcf at torproject.org
Wed Jan 29 19:42:52 UTC 2020


commit 50673d49437c55aba2a5f7f31819bcae60406b07
Author: Cecylia Bocovich <cohosh at torproject.org>
Date:   Wed Jan 29 11:40:29 2020 -0500

    Remove client test with nil broker
    
    We are no longer checking for nil BrokerChannels in Catch because this
    case is caught from the return values of NewBrokerChannel. This change
    caused a no longer necessary unit test to hang.
---
 client/lib/lib_test.go | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/client/lib/lib_test.go b/client/lib/lib_test.go
index d48c301..91a9809 100644
--- a/client/lib/lib_test.go
+++ b/client/lib/lib_test.go
@@ -271,12 +271,6 @@ func TestSnowflakeClient(t *testing.T) {
 			So(d.BrokerChannel, ShouldNotBeNil)
 			So(d.BrokerChannel.Host, ShouldEqual, "test")
 		})
-		Convey("WebRTCDialer cannot Catch a snowflake with nil broker.", func() {
-			d := NewWebRTCDialer(nil, nil)
-			conn, err := d.Catch()
-			So(conn, ShouldBeNil)
-			So(err, ShouldNotBeNil)
-		})
 		SkipConvey("WebRTCDialer can Catch a snowflake.", func() {
 			broker := &BrokerChannel{Host: "test"}
 			d := NewWebRTCDialer(broker, nil)



More information about the tor-commits mailing list