[tor-commits] [tor/master] practracker: Test practracker exit status

[teor at torproject.org]

commit fa038e561757d4280957db715da0a3392e8084f2
Author: teor <teor at torproject.org>
Date:   Tue Jan 14 17:23:41 2020 +1000

    practracker: Test practracker exit status
    
    Part of 32705.
---
 scripts/maint/practracker/test_practracker.sh                 | 2 +-
 scripts/maint/practracker/testdata/ex0-expected.txt           | 1 +
 scripts/maint/practracker/testdata/ex1-expected.txt           | 1 +
 scripts/maint/practracker/testdata/ex1-overbroad-expected.txt | 1 +
 4 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/scripts/maint/practracker/test_practracker.sh b/scripts/maint/practracker/test_practracker.sh
index 43e7b0a32..28d3d82e6 100755
--- a/scripts/maint/practracker/test_practracker.sh
+++ b/scripts/maint/practracker/test_practracker.sh
@@ -40,7 +40,7 @@ run_practracker() {
         --max-h-include-count=0 \
         --max-include-count=0 \
         --terse \
-        "${DATA}/" "$@" || true
+        "${DATA}/" "$@" || echo "practracker exit status: $?"
 }
 compare() {
     # we can't use cmp because we need to use -b for windows
diff --git a/scripts/maint/practracker/testdata/ex0-expected.txt b/scripts/maint/practracker/testdata/ex0-expected.txt
index dc41c8700..c9fb83bac 100644
--- a/scripts/maint/practracker/testdata/ex0-expected.txt
+++ b/scripts/maint/practracker/testdata/ex0-expected.txt
@@ -10,3 +10,4 @@ problem function-size b.c:bar() 5
 problem file-size header.h 8
 problem include-count header.h 4
 problem dependency-violation header.h 3
+practracker exit status: 11
diff --git a/scripts/maint/practracker/testdata/ex1-expected.txt b/scripts/maint/practracker/testdata/ex1-expected.txt
index 7800a2cd0..2713338ae 100644
--- a/scripts/maint/practracker/testdata/ex1-expected.txt
+++ b/scripts/maint/practracker/testdata/ex1-expected.txt
@@ -2,3 +2,4 @@ Unusual pattern permitted.h in scripts/maint/practracker/testdata
 problem function-size a.c:i_am_a_function() 9
 (warning) problem function-size a.c:another_function() 12
 problem function-size b.c:foo() 4
+practracker exit status: 2
diff --git a/scripts/maint/practracker/testdata/ex1-overbroad-expected.txt b/scripts/maint/practracker/testdata/ex1-overbroad-expected.txt
index ed3cbb29f..5ca480dc0 100644
--- a/scripts/maint/practracker/testdata/ex1-overbroad-expected.txt
+++ b/scripts/maint/practracker/testdata/ex1-overbroad-expected.txt
@@ -1,3 +1,4 @@
 Unusual pattern permitted.h in scripts/maint/practracker/testdata
 problem file-size a.c 45 -> 41
 problem file-size z.c 100 -> 0
+practracker exit status: 3