[tor-commits] [stem/master] Drop 'GETINFO status/fresh-relay-descs' test

atagar at torproject.org atagar at torproject.org
Sun Jan 5 21:39:28 UTC 2020


commit 983afa8a67e8ef013ff8c03afbd75d0219ea1188
Author: Damian Johnson <atagar at torproject.org>
Date:   Fri Jan 3 15:32:58 2020 -0800

    Drop 'GETINFO status/fresh-relay-descs' test
    
    This test fails ~30% of the time because tor has not yet determined its
    address...
    
      https://trac.torproject.org/projects/tor/ticket/32873
    
    We can reintroduce this test if the test or getinfo command can be more
    reliable.
---
 test/integ/control/controller.py | 22 ----------------------
 1 file changed, 22 deletions(-)

diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py
index a32f66f0..428f516e 100644
--- a/test/integ/control/controller.py
+++ b/test/integ/control/controller.py
@@ -256,28 +256,6 @@ class TestController(unittest.TestCase):
       self.assertEqual({}, controller.get_info([], {}))
 
   @test.require.controller
-  def test_getinfo_freshrelaydescs(self):
-    """
-    Exercises 'GETINFO status/fresh-relay-descs'.
-    """
-
-    with test.runner.get_runner().get_tor_controller() as controller:
-      response = controller.get_info('status/fresh-relay-descs')
-      div = response.find('\nextra-info ')
-      nickname = controller.get_conf('Nickname')
-
-      if div == -1:
-        self.fail('GETINFO response should have both a server and extrainfo descriptor:\n%s' % response)
-
-      server_desc = stem.descriptor.server_descriptor.ServerDescriptor(response[:div], validate = True)
-      extrainfo_desc = stem.descriptor.extrainfo_descriptor.ExtraInfoDescriptor(response[div:], validate = True)
-
-      self.assertEqual(nickname, server_desc.nickname)
-      self.assertEqual(nickname, extrainfo_desc.nickname)
-      self.assertEqual(controller.get_info('address'), server_desc.address)
-      self.assertEqual(test.runner.ORPORT, server_desc.or_port)
-
-  @test.require.controller
   @test.require.online
   def test_getinfo_dir_status(self):
     """





More information about the tor-commits mailing list