[tor-commits] [tor/master] Correct a comment in channel_tls_process_cell.

asn at torproject.org asn at torproject.org
Wed Sep 25 11:19:13 UTC 2019


commit 2d744de355d65c8f13c721558025bbfbfaa0758e
Author: Nick Mathewson <nickm at torproject.org>
Date:   Tue Sep 17 11:42:19 2019 -0400

    Correct a comment in channel_tls_process_cell.
---
 src/core/or/channeltls.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/core/or/channeltls.c b/src/core/or/channeltls.c
index 2bc2cba31..f72779938 100644
--- a/src/core/or/channeltls.c
+++ b/src/core/or/channeltls.c
@@ -1073,7 +1073,8 @@ channel_tls_handle_cell(cell_t *cell, or_connection_t *conn)
     return;
 
   /* Reject all but VERSIONS and NETINFO when handshaking. */
-  /* (VERSIONS should actually be impossible; it's variable-length.) */
+  /* (VERSIONS actually indicates a protocol warning: it's variable-length,
+   * so if it reaches this function, we're on a v1 connection.) */
   if (handshaking && cell->command != CELL_VERSIONS &&
       cell->command != CELL_NETINFO) {
     log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL,





More information about the tor-commits mailing list