[tor-commits] [tor/master] main: remove level number comments from the subsystem list (0.4.0)

[dgoulet at torproject.org]

commit 2e2a35b6943810257b6917648db90ed5d46505e1
Author: teor <teor at torproject.org>
Date:   Tue Sep 10 08:35:56 2019 +1000

    main: remove level number comments from the subsystem list (0.4.0)
    
    These levels get out of date really easily: we'll implement a level
    dump command in tor in 31614.
    
    They also cause conflicts and inconsistencies when merging forward
    level changes.
    
    Part of 31615.
---
 src/app/main/subsystem_list.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/src/app/main/subsystem_list.c b/src/app/main/subsystem_list.c
index 383417618..81b58cf70 100644
--- a/src/app/main/subsystem_list.c
+++ b/src/app/main/subsystem_list.c
@@ -27,23 +27,25 @@
 
 /**
  * Global list of the subsystems in Tor, in the order of their initialization.
+ * Want to know the exact level numbers?
+ * We'll implement a level dump command in #31614.
  **/
 const subsys_fns_t *tor_subsystems[] = {
-  &sys_winprocess, /* -100 */
-  &sys_torerr, /* -100 */
-  &sys_wallclock, /* -99 */
-  &sys_threads, /* -95 */
-  &sys_logging, /* -90 */
-  &sys_time, /* -90 */
-  &sys_network, /* -90 */
-  &sys_compress, /* -70 */
-  &sys_crypto, /* -60 */
-  &sys_tortls, /* -50 */
-  &sys_process, /* -35 */
+  &sys_winprocess,
+  &sys_torerr,
+  &sys_wallclock,
+  &sys_threads,
+  &sys_logging,
+  &sys_time,
+  &sys_network,
+  &sys_compress,
+  &sys_crypto,
+  &sys_tortls,
+  &sys_process,
 
-  &sys_orconn_event, /* -33 */
-  &sys_ocirc_event, /* -32 */
-  &sys_btrack, /* -30 */
+  &sys_orconn_event,
+  &sys_ocirc_event,
+  &sys_btrack,
 };
 
 const unsigned n_tor_subsystems = ARRAY_LENGTH(tor_subsystems);