[tor-commits] [tor/master] string: macOS --enable-fragile-hardening uses safe string functions

nickm at torproject.org nickm at torproject.org
Wed Sep 4 13:53:44 UTC 2019


commit 063cf9cd23d28c8b5678373040622321882026c2
Author: teor <teor at torproject.org>
Date:   Thu Aug 29 12:40:32 2019 +1000

    string: macOS --enable-fragile-hardening uses safe string functions
    
    Comment-only change.
---
 src/lib/string/compat_string.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/lib/string/compat_string.h b/src/lib/string/compat_string.h
index 4f30bf539..ffc892c3e 100644
--- a/src/lib/string/compat_string.h
+++ b/src/lib/string/compat_string.h
@@ -39,6 +39,9 @@ static inline int strcasecmp(const char *a, const char *b) {
  * appear to have a severe bug that can sometimes cause aborts in Tor.
  * Instead, use the non-checking variants.  This is sad.
  *
+ * (If --enable-fragile-hardening is passed to configure, we use the hardened
+ * variants, which do not suffer from this issue.)
+ *
  * See https://trac.torproject.org/projects/tor/ticket/15205
  */
 #undef strlcat





More information about the tor-commits mailing list