[tor-commits] [tor/master] test_options: stop generating old_data entirely.

nickm at torproject.org nickm at torproject.org
Fri Oct 25 12:15:41 UTC 2019


commit 24ee44df90d12eb98ba5a39638963696ce2f8012
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Oct 23 18:03:24 2019 -0400

    test_options: stop generating old_data entirely.
    
    Now that we no longer use it anywhere, we can remove this variable
    from the test data structure.
---
 src/test/test_options.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/test/test_options.c b/src/test/test_options.c
index 941ca94d9..374fa8b18 100644
--- a/src/test/test_options.c
+++ b/src/test/test_options.c
@@ -384,7 +384,6 @@ fixed_get_uname(void)
 }
 
 typedef struct {
-  or_options_t *old_opt;
   or_options_t *opt;
 } options_test_data_t;
 
@@ -398,10 +397,8 @@ get_options_test_data(const char *conf)
   config_line_t *cl=NULL;
   options_test_data_t *result = tor_malloc(sizeof(options_test_data_t));
   result->opt = options_new();
-  result->old_opt = options_new();
 
   options_init(result->opt);
-  options_init(result->old_opt);
 
   rv = config_get_lines(conf, &cl, 1);
   tt_int_op(rv, OP_EQ, 0);
@@ -433,7 +430,6 @@ static void
 free_options_test_data(options_test_data_t *td)
 {
   if (!td) return;
-  or_options_free(td->old_opt);
   or_options_free(td->opt);
   tor_free(td);
 }





More information about the tor-commits mailing list