[tor-commits] [tor/maint-0.4.0] Try using make -k in the Appveyor configuration

teor at torproject.org teor at torproject.org
Tue Oct 22 22:49:04 UTC 2019


commit 49a11f8a8a61a4d8b8657a98291862ffc96e99d9
Author: Nick Mathewson <nickm at torproject.org>
Date:   Mon Sep 23 15:04:54 2019 -0400

    Try using make -k in the Appveyor configuration
    
    Frequently, when a patch fails, it has failures in several files.
    Using the "-k" flag will let us learn all the compilation errors,
    not just the first one that the compiler hits.
    
    Based on a patch by rl1987.
    
    Closes ticket 31372.
---
 .appveyor.yml                | 6 +++---
 changes/ticket31372_appveyor | 4 ++++
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/.appveyor.yml b/.appveyor.yml
index 9913bf3bd..25f87fa45 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -83,8 +83,8 @@ build_script:
              # configure its flags. liblzma just works.
              #>
             Execute-Bash "ZSTD_CFLAGS='-L/${env:compiler_path}/include' ZSTD_LIBS='-L/${env:compiler_path}/lib -lzstd' ../configure --prefix=/${env:compiler_path} --build=${env:target} --host=${env:target} --with-openssl-dir=/${env:compiler_path} --disable-asciidoc --enable-fatal-warnings ${env:hardening}"
-            Execute-Bash "V=1 make -j2"
-            Execute-Bash "V=1 make -j2 install"
+            Execute-Bash "V=1 make -k -j2"
+            Execute-Bash "V=1 make -k -j2 install"
      }
 
 test_script:
@@ -95,7 +95,7 @@ test_script:
             $buildpath = @("C:\msys64\${env:compiler_path}\bin") + $oldpath
             $env:Path = $buildpath -join ';'
             Set-Location "${env:build}"
-            Execute-Bash "VERBOSE=1 make -j2 check"
+            Execute-Bash "VERBOSE=1 make -k -j2 check"
     }
 
 on_finish:
diff --git a/changes/ticket31372_appveyor b/changes/ticket31372_appveyor
new file mode 100644
index 000000000..e7bb03182
--- /dev/null
+++ b/changes/ticket31372_appveyor
@@ -0,0 +1,4 @@
+  o Minor features (continuous integration):
+    - When building on Appveyor, pass the "-k" flag to make, so that
+      we are informed of all compilation failures, not just the first
+      one or two. Closes part of ticket 31372.





More information about the tor-commits mailing list