[tor-commits] [tor-browser/tor-browser-68.1.0esr-9.0-2] Bug 29013: Enable stack protection for Firefox on Windows

[boklm at torproject.org]

commit 4b8a33af9610111d87dc5a901d06bcc20f1cc7b0
Author: Georg Koppen <gk at torproject.org>
Date:   Tue Oct 1 07:46:13 2019 +0000

    Bug 29013: Enable stack protection for Firefox on Windows
---
 build/moz.configure/toolchain.configure | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/build/moz.configure/toolchain.configure b/build/moz.configure/toolchain.configure
index 68364075f006..3bcf403bceec 100755
--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1676,12 +1676,10 @@ def security_hardening_cflags(hardening_flag, asan, optimize, c_compiler, target
         # Enable only if hardening is not disabled and ASAN is
         # not on as ASAN will catch the crashes for us
         if compiler_is_gccish and not asan:
-            # mingw-clang cross-compile toolchain has bugs with stack protector
-            if target.os != 'WINNT' or c_compiler == 'gcc':
-                flags.append("-fstack-protector-strong")
-                ldflags.append("-fstack-protector-strong")
-                js_flags.append("-fstack-protector-strong")
-                js_ldflags.append("-fstack-protector-strong")
+            flags.append("-fstack-protector-strong")
+            ldflags.append("-fstack-protector-strong")
+            js_flags.append("-fstack-protector-strong")
+            js_ldflags.append("-fstack-protector-strong")
 
         # ASLR ------------------------------------------------
         # ASLR (dynamicbase) is enabled by default in clang-cl; but the