[tor-commits] [tor/master] test: New behavior on IP retry for HSv3

[nickm at torproject.org]

commit 7c1b2fceb7d46aed8945d86806dc791f97c47125
Author: Neel Chauhan <neel at neelc.org>
Date:   Wed Sep 18 11:40:10 2019 -0400

    test: New behavior on IP retry for HSv3
    
    Unit test for #31652 where if we are over the retry limit for the IP but we
    have an established circuit, we don't remove the IP.
    
    Part of #31652
---
 src/test/test_hs_service.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c
index a2594ed6a..efe4166bf 100644
--- a/src/test/test_hs_service.c
+++ b/src/test/test_hs_service.c
@@ -1298,6 +1298,11 @@ test_service_event(void *arg)
     run_housekeeping_event(now);
     tt_int_op(digest256map_size(service->desc_current->intro_points.map),
               OP_EQ, 1);
+    /* No removal if we have an established circuit after retries. */
+    ip->circuit_retries = MAX_INTRO_POINT_CIRCUIT_RETRIES + 1;
+    run_housekeeping_event(now);
+    tt_int_op(digest256map_size(service->desc_current->intro_points.map),
+              OP_EQ, 1);
     /* Remove the IP object at once for the next test. */
     ip->circuit_retries = MAX_INTRO_POINT_CIRCUIT_RETRIES + 1;
     ip->circuit_established = 0;