[tor-commits] [tor/master] practracker/includes.py: Don't read editor temp files

teor at torproject.org teor at torproject.org
Tue Nov 26 07:52:39 UTC 2019


commit fadd292bf05e6fedf61e25f43079920c9ea3c117
Author: teor <teor at torproject.org>
Date:   Tue Nov 26 17:50:56 2019 +1000

    practracker/includes.py: Don't read editor temp files
    
    (Or any files that start with "." or "#".)
    
    Obviously correct changes to already-reviewed code.
---
 scripts/maint/practracker/includes.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/scripts/maint/practracker/includes.py b/scripts/maint/practracker/includes.py
index 1d43bd58e..f2d91b63a 100755
--- a/scripts/maint/practracker/includes.py
+++ b/scripts/maint/practracker/includes.py
@@ -36,7 +36,11 @@ def warn(msg):
 def fname_is_c(fname):
     """ Return true iff 'fname' is the name of a file that we should
         search for possibly disallowed #include directives. """
-    return fname.endswith(".h") or fname.endswith(".c")
+    if fname.endswith(".h") or fname.endswith(".c"):
+        bname = os.path.basename(fname)
+        return not (bname.startswith(".") or bname.startswith("#"))
+    else:
+        return False
 
 INCLUDE_PATTERN = re.compile(r'\s*#\s*include\s+"([^"]*)"')
 RULES_FNAME = ".may_include"



More information about the tor-commits mailing list