[tor-commits] [snowflake/master] Changed variable name for multiplexed clients

cohosh at torproject.org cohosh at torproject.org
Mon Nov 11 15:15:53 UTC 2019


commit 300a23c6a0071a910ee3b56f7bf14e4f9529ee3f
Author: Cecylia Bocovich <cohosh at torproject.org>
Date:   Thu Oct 31 12:08:43 2019 -0400

    Changed variable name for multiplexed clients
    
    The variable maxNumClients was unused, while connectionsPerClient was
    used for spawning multiple proxyPairs. The former is a more appropriate
    name for the multiplexing behaviour we use it for.
    
    Multiplexing now just works thanks to implementing ticket #31310.
---
 proxy/config.js    | 2 --
 proxy/snowflake.js | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/proxy/config.js b/proxy/config.js
index 95ae92e..9564f82 100644
--- a/proxy/config.js
+++ b/proxy/config.js
@@ -24,8 +24,6 @@ Config.prototype.defaultBrokerPollInterval = 300.0 * 1000;
 
 Config.prototype.maxNumClients = 1;
 
-Config.prototype.connectionsPerClient = 1;
-
 // TODO: Different ICE servers.
 Config.prototype.pcConfig = {
   iceServers: [
diff --git a/proxy/snowflake.js b/proxy/snowflake.js
index ba1ef03..0e9730e 100644
--- a/proxy/snowflake.js
+++ b/proxy/snowflake.js
@@ -119,7 +119,7 @@ class Snowflake {
   }
 
   makeProxyPair() {
-    if (this.proxyPairs.length >= this.config.connectionsPerClient) {
+    if (this.proxyPairs.length >= this.config.maxNumClients) {
       return null;
     }
     var pair;



More information about the tor-commits mailing list