[tor-commits] [tor/master] Makefile: Fix "make check-includes" for out-of-tree builds

teor at torproject.org teor at torproject.org
Wed Nov 6 07:05:20 UTC 2019


commit 10ef7a31cfa896fb8a4eddde92c4b7d1e7477ad6
Author: teor <teor at torproject.org>
Date:   Wed Nov 6 12:29:35 2019 +1000

    Makefile: Fix "make check-includes" for out-of-tree builds
    
    Previously, it would run on the build tree, which did not contain
    any sources.
    
    Fixes bug 31335; bugfix on 0.3.5.1-alpha.
---
 Makefile.am      | 2 +-
 changes/bug31335 | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 485324fc7..03593df16 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -370,7 +370,7 @@ endif
 
 check-includes:
 if USEPYTHON
-	$(PYTHON) $(top_srcdir)/scripts/maint/practracker/includes.py
+	$(PYTHON) $(top_srcdir)/scripts/maint/practracker/includes.py $(top_srcdir)
 endif
 
 check-best-practices:
diff --git a/changes/bug31335 b/changes/bug31335
new file mode 100644
index 000000000..f633cf8b2
--- /dev/null
+++ b/changes/bug31335
@@ -0,0 +1,3 @@
+  o Minor bugfixes (code quality):
+    - Fix "make check-includes" so it runs correctly on out-of-tree builds.
+      Fixes bug 31335; bugfix on 0.3.5.1-alpha.





More information about the tor-commits mailing list