[tor-commits] [snowflake/master] Fix some linting warnings for "Line exceeds maximum allowed length."

arlo at torproject.org arlo at torproject.org
Thu May 16 16:08:58 UTC 2019


commit dad53932a2b0f136ef52f5e66b3ae262a6ad9e1a
Author: Arlo Breault <arlolra at gmail.com>
Date:   Wed May 8 17:27:00 2019 -0400

    Fix some linting warnings for "Line exceeds maximum allowed length."
---
 proxy/init-badge.coffee          | 4 +++-
 proxy/snowflake.coffee           | 5 ++++-
 proxy/spec/proxypair.spec.coffee | 8 ++++++--
 proxy/spec/util.spec.coffee      | 6 +++++-
 proxy/spec/websocket.spec.coffee | 5 +++--
 proxy/util.coffee                | 4 ++--
 proxy/websocket.coffee           | 7 ++++---
 7 files changed, 27 insertions(+), 12 deletions(-)

diff --git a/proxy/init-badge.coffee b/proxy/init-badge.coffee
index 295f84b..7802ca4 100644
--- a/proxy/init-badge.coffee
+++ b/proxy/init-badge.coffee
@@ -21,7 +21,9 @@ init = () ->
   config = new Config
 
   if 'off' != query['ratelimit']
-    config.rateLimitBytes = Params.getByteCount(query, 'ratelimit', config.rateLimitBytes)
+    config.rateLimitBytes = Params.getByteCount(
+      query,'ratelimit', config.rateLimitBytes
+    )
 
   ui = null
   if (document.getElementById('badge') != null)
diff --git a/proxy/snowflake.coffee b/proxy/snowflake.coffee
index 66885d9..bb03cf0 100644
--- a/proxy/snowflake.coffee
+++ b/proxy/snowflake.coffee
@@ -82,7 +82,10 @@ class Snowflake
       recv = @broker.getClientOffer pair.id
       recv.then (desc) =>
         @receiveOffer pair, desc
-        countdown('Serving 1 new client.', @config.defaultBrokerPollInterval / 1000)
+        countdown(
+          'Serving 1 new client.',
+          @config.defaultBrokerPollInterval / 1000
+        )
       , (err) =>
         countdown(err, @config.defaultBrokerPollInterval / 1000)
       @retries++
diff --git a/proxy/spec/proxypair.spec.coffee b/proxy/spec/proxypair.spec.coffee
index 87aeb55..a890780 100644
--- a/proxy/spec/proxypair.spec.coffee
+++ b/proxy/spec/proxypair.spec.coffee
@@ -96,7 +96,9 @@ describe 'ProxyPair', ->
       }
       spyOn pp.client, 'send'
       spyOn pp.relay, 'send'
-      msg = new MessageEvent("message", { data: Uint8Array.from([1, 2, 3]).buffer })
+      msg = new MessageEvent("message", {
+        data: Uint8Array.from([1, 2, 3]).buffer
+      })
       pp.onClientToRelayMessage(msg)
       pp.flush()
       expect(pp.client.send).not.toHaveBeenCalled()
@@ -105,7 +107,9 @@ describe 'ProxyPair', ->
     it 'proxies data from relay to client', ->
       spyOn pp.client, 'send'
       spyOn pp.relay, 'send'
-      msg = new MessageEvent("message", { data: Uint8Array.from([4, 5, 6]).buffer })
+      msg = new MessageEvent("message", {
+        data: Uint8Array.from([4, 5, 6]).buffer
+      })
       pp.onRelayToClientMessage(msg)
       pp.flush()
       expect(pp.client.send).toHaveBeenCalledWith arrayMatching([4, 5, 6])
diff --git a/proxy/spec/util.spec.coffee b/proxy/spec/util.spec.coffee
index 19f0041..88b67b2 100644
--- a/proxy/spec/util.spec.coffee
+++ b/proxy/spec/util.spec.coffee
@@ -118,6 +118,7 @@ describe 'Parse', ->
       expected: '1.2.3.4'
     ,
       # Modified from SDP sent by snowflake-client.
+      # coffeelint: disable
       sdp: """
            v=0
            o=- 7860378660295630295 2 IN IP4 127.0.0.1
@@ -137,6 +138,7 @@ describe 'Parse', ->
            a=mid:data
            a=sctpmap:5000 webrtc-datachannel 1024
            """
+      # coffeelint: enable
       expected: '1.2.3.4'
     ,
       # Improper character within IPv4
@@ -164,7 +166,9 @@ describe 'Parse', ->
         # We represent the test cases with LF line endings for convenience, and
         # test them both that way and with CRLF line endings.
         expect(Parse.ipFromSDP(test.sdp)?.toLowerCase()).toEqual(test.expected)
-        expect(Parse.ipFromSDP(test.sdp.replace(/\n/, "\r\n"))?.toLowerCase()).toEqual(test.expected)
+        expect(
+          Parse.ipFromSDP(test.sdp.replace(/\n/, "\r\n"))?.toLowerCase()
+        ).toEqual(test.expected)
 
 describe 'query string', ->
   it 'should parse correctly', ->
diff --git a/proxy/spec/websocket.spec.coffee b/proxy/spec/websocket.spec.coffee
index 178bcfd..3818e2a 100644
--- a/proxy/spec/websocket.spec.coffee
+++ b/proxy/spec/websocket.spec.coffee
@@ -24,8 +24,9 @@ describe 'BuildUrl', ->
   it 'should handle params', ->
     expect WS.buildUrl 'http', 'example.com', 80, '/test', [['k', '%#v']]
       .toBe 'http://example.com/test?k=%25%23v'
-    expect WS.buildUrl 'http', 'example.com', 80, '/test', [['a', 'b'], ['c', 'd']]
-      .toBe 'http://example.com/test?a=b&c=d'
+    expect(WS.buildUrl(
+      'http', 'example.com', 80, '/test', [['a', 'b'], ['c', 'd']]
+    )).toBe 'http://example.com/test?a=b&c=d'
   it 'should handle ips', ->
     expect WS.buildUrl 'http', '1.2.3.4'
       .toBe 'http://1.2.3.4'
diff --git a/proxy/util.coffee b/proxy/util.coffee
index b8057fb..02b6024 100644
--- a/proxy/util.coffee
+++ b/proxy/util.coffee
@@ -124,8 +124,8 @@ class Parse
       return null if null == units
     count * Number(units)
 
-  # Parse a connection-address out of the "c=" Connection Data field of a session
-  # description. Return undefined if none is found.
+  # Parse a connection-address out of the "c=" Connection Data field of a
+  # session description. Return undefined if none is found.
   # https://tools.ietf.org/html/rfc4566#section-5.7
   @ipFromSDP: (sdp) ->
     for pattern in [
diff --git a/proxy/websocket.coffee b/proxy/websocket.coffee
index 00a65a8..1e75ac1 100644
--- a/proxy/websocket.coffee
+++ b/proxy/websocket.coffee
@@ -52,9 +52,10 @@ class WS
     url = @buildUrl wsProtocol, addr.host, addr.port, '/', params
     ws = new WebSocket url
     ###
-    'User agents can use this as a hint for how to handle incoming binary data: if
-    the attribute is set to 'blob', it is safe to spool it to disk, and if it is
-    set to 'arraybuffer', it is likely more efficient to keep the data in memory.'
+    'User agents can use this as a hint for how to handle incoming binary data:
+    if the attribute is set to 'blob', it is safe to spool it to disk, and if it
+    is set to 'arraybuffer', it is likely more efficient to keep the data in
+    memory.'
     ###
     ws.binaryType = 'arraybuffer'
     ws





More information about the tor-commits mailing list