[tor-commits] [tor/master] routerkeys: Log failures at info-level in make_tap_onion_key_crosscert()

[asn at torproject.org]

commit 0c0f21582285bec0fe68f71e293158eeedaeeaa3
Author: teor <teor at torproject.org>
Date:   Tue Feb 19 18:52:54 2019 +1000

    routerkeys: Log failures at info-level in make_tap_onion_key_crosscert()
---
 src/feature/relay/routerkeys.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/feature/relay/routerkeys.c b/src/feature/relay/routerkeys.c
index bdd7a82b5..d965777ad 100644
--- a/src/feature/relay/routerkeys.c
+++ b/src/feature/relay/routerkeys.c
@@ -706,6 +706,8 @@ make_tap_onion_key_crosscert(const crypto_pk_t *onion_key,
 
   *len_out = 0;
   if (crypto_pk_get_digest(rsa_id_key, (char*)signed_data) < 0) {
+    log_info(LD_OR, "crypto_pk_get_digest failed in "
+                    "make_tap_onion_key_crosscert!");
     return NULL;
   }
   memcpy(signed_data + DIGEST_LEN, master_id_key->pubkey, ED25519_PUBKEY_LEN);
@@ -713,8 +715,12 @@ make_tap_onion_key_crosscert(const crypto_pk_t *onion_key,
   int r = crypto_pk_private_sign(onion_key,
                                (char*)signature, sizeof(signature),
                                (const char*)signed_data, sizeof(signed_data));
-  if (r < 0)
+  if (r < 0) {
+    /* It's probably missing the private key */
+    log_info(LD_OR, "crypto_pk_private_sign failed in "
+                    "make_tap_onion_key_crosscert!");
     return NULL;
+  }
 
   *len_out = r;