[tor-commits] [sbws/master] fixup! new: v3bwfile: Set measurements exclusion KeyValues

[juga at torproject.org]

commit b60684b032b453a1af80692c44af9950fa1d345c
Author: juga0 <juga at riseup.net>
Date:   Thu Mar 14 11:52:00 2019 +0000

    fixup! new: v3bwfile: Set measurements exclusion KeyValues
---
 sbws/lib/v3bwfile.py | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sbws/lib/v3bwfile.py b/sbws/lib/v3bwfile.py
index 99b3914..80d4ca6 100644
--- a/sbws/lib/v3bwfile.py
+++ b/sbws/lib/v3bwfile.py
@@ -528,6 +528,18 @@ class V3BWLine(object):
                 str(max(relay_recent_priority_list_counts))
 
         success_results = [r for r in results if isinstance(r, ResultSuccess)]
+
+        # NOTE: The following 4 conditions exclude relays from the bandwidth
+        # file when the measurements does not satisfy some rules, what makes
+        # the relay non-`eligible`.
+        # In BANDWIDTH_LINE_KEY_VALUES_MONITOR it is explained what they mean.
+        # In BW_HEADER_KEYVALUES_RECENT_MEASUREMENTS_EXCLUDED it is also
+        # explained the what it means the strings returned.
+        # They rules were introduced in #28061 and #27338
+        # In #28565 we introduce the KeyValues to know why they're excluded.
+        # In #28563 will include again these lines, but make them unparseable
+        # by Tor.
+        # This might confirm #28042.
         kwargs['relay_recent_measurement_exclusion_not_success_count'] = \
             len(results) - len(success_results)
         if not success_results: