[tor-commits] [tor/master] Fix shellcheck warnings in test_rust.sh

nickm at torproject.org nickm at torproject.org
Fri Mar 1 13:22:47 UTC 2019


commit 10455aeff228042ee769205e43788d0e81cde910
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Fri Feb 1 20:53:40 2019 +0200

    Fix shellcheck warnings in test_rust.sh
---
 changes/ticket29064   | 2 ++
 src/test/test_rust.sh | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/changes/ticket29064 b/changes/ticket29064
new file mode 100644
index 000000000..616b8aa77
--- /dev/null
+++ b/changes/ticket29064
@@ -0,0 +1,2 @@
+  o Code simplification and refactoring (shell scripts):
+    - Fix shellcheck warning in test_rust.sh. Fixes issue 29064.
diff --git a/src/test/test_rust.sh b/src/test/test_rust.sh
index 00b3e88d3..da2bd32d2 100755
--- a/src/test/test_rust.sh
+++ b/src/test/test_rust.sh
@@ -16,10 +16,10 @@ for cargo_toml_dir in "${abs_top_srcdir:-../../..}"/src/rust/*; do
     if [ -e "${cargo_toml_dir}/Cargo.toml" ]; then
 	cd "${abs_top_builddir:-../../..}/src/rust" && \
 	    CARGO_TARGET_DIR="${abs_top_builddir:-../../..}/src/rust/target" \
-	    "${CARGO:-cargo}" test ${CARGO_ONLINE-"--frozen"} \
+	    "${CARGO:-cargo}" test "${CARGO_ONLINE-'--frozen'}" \
             --features "test_linking_hack" \
-            --target $rustc_host \
-	    ${EXTRA_CARGO_OPTIONS} \
+            --target "$rustc_host" \
+	    "${EXTRA_CARGO_OPTIONS}" \
 	    --manifest-path "${cargo_toml_dir}/Cargo.toml" || exitcode=1
     fi
 done





More information about the tor-commits mailing list