[tor-commits] [tor/master] Shellcheck all the scripts

[nickm at torproject.org]

commit 19dbd431c52994fc14bf7cb2e1a1a0dc686c2599
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Sun Jun 9 18:20:36 2019 +0300

    Shellcheck all the scripts
---
 Makefile.am | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index 7a0d40d6a..df30e0b59 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -224,10 +224,19 @@ test: all
 shellcheck:
         # Only use shellcheck if it is present
 	if command -v shellcheck; then \
-	        find $(top_srcdir)/scripts/ -name "*.sh" -exec shellcheck {} +; \
+                find "$(top_srcdir)" -name "*.sh" -not -path "$(top_srcdir)/src/ext/*" -exec shellcheck {} +; \
 	        if [ -d "$(top_srcdir)/scripts/test" ]; then \
                         shellcheck $(top_srcdir)/scripts/test/cov-diff $(top_srcdir)/scripts/test/coverage; \
                 fi; \
+                if [ -e "$(top_srcdir)/contrib/dirauth-tools/nagios-check-tor-authority-cert" ]; then \
+                        shellcheck "$(top_srcdir)/contrib/dirauth-tools/nagios-check-tor-authority-cert"; \
+                fi; \
+                if [ -e "$(top_srcdir)/contrib/client-tools/torify" ]; then \
+                        shellcheck "$(top_srcdir)/contrib/client-tools/torify"; \
+                fi; \
+                if [ -d "$(top_srcdir)/scripts/git" ]; then \
+                        shellcheck $(top_srcdir)/scripts/git/*.git-hook; \
+                fi; \
 	fi
 
 check-local: check-spaces check-changes check-includes check-best-practices shellcheck