[tor-commits] [tor/master] Further clarify our clarification about the type of POSINT

dgoulet at torproject.org dgoulet at torproject.org
Tue Jul 23 13:50:59 UTC 2019


commit f0074372928829835adf6aa2dde9af712097c7c0
Author: Nick Mathewson <nickm at torproject.org>
Date:   Wed Jun 19 08:14:59 2019 -0400

    Further clarify our clarification about the type of POSINT
---
 src/lib/conf/conftypes.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/lib/conf/conftypes.h b/src/lib/conf/conftypes.h
index b03234b62..e66ab3d5a 100644
--- a/src/lib/conf/conftypes.h
+++ b/src/lib/conf/conftypes.h
@@ -73,10 +73,10 @@ typedef enum config_type_t {
 typedef union {
   char **STRING;
   char **FILENAME;
-  int *POSINT; /* yes, really: Even though the confparse type is called
-                * "POSINT", it still uses the C int type -- it just enforces
-                * that the values are in range [0,INT_MAX].
-              */
+  int *POSINT; /* yes, this is really an int, and not an unsigned int.  For
+                * historical reasons, many configuration values are restricted
+                * to the range [0,INT_MAX], and stored in signed ints.
+                */
   uint64_t *UINT64;
   int *INT;
   int *INTERVAL;





More information about the tor-commits mailing list