[tor-commits] [tor/maint-0.3.5] Log an HSDesc we failed to parse at Debug loglevel

[nickm at torproject.org]

commit 712a622fcecd43a7a50c7b35a9811f1210aeadb8
Author: rl1987 <rl1987 at sdf.lonestar.org>
Date:   Mon Jan 21 12:06:46 2019 +0200

    Log an HSDesc we failed to parse at Debug loglevel
---
 changes/bug29135          | 5 +++++
 src/feature/hs/hs_cache.c | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/changes/bug29135 b/changes/bug29135
new file mode 100644
index 000000000..fd7b1ae80
--- /dev/null
+++ b/changes/bug29135
@@ -0,0 +1,5 @@
+  o Minor bugfixes (onion services, logging):
+    - In hs_cache_store_as_client() log an HSDesc we failed to parse at Debug
+      loglevel. Tor used to log it at Warning loglevel, which caused
+      very long log lines to appear for some users. Fixes bug 29135; bugfix on
+      0.3.2.1-alpha.
diff --git a/src/feature/hs/hs_cache.c b/src/feature/hs/hs_cache.c
index 82ce68642..05f9940ae 100644
--- a/src/feature/hs/hs_cache.c
+++ b/src/feature/hs/hs_cache.c
@@ -778,8 +778,8 @@ hs_cache_store_as_client(const char *desc_str,
   /* Create client cache descriptor object */
   client_desc = cache_client_desc_new(desc_str, identity_pk);
   if (!client_desc) {
-    log_warn(LD_GENERAL, "Failed to parse received descriptor %s.",
-             escaped(desc_str));
+    log_warn(LD_GENERAL, "HSDesc parsing failed!");
+    log_debug(LD_GENERAL, "Failed to parse HSDesc: %s.", escaped(desc_str));
     goto err;
   }